Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: add resolve lock logic for mvcc get key loading schema diff (#48330) #48418

Merged
merged 2 commits into from
Nov 9, 2023
Merged

domain: add resolve lock logic for mvcc get key loading schema diff (#48330) #48418

merged 2 commits into from
Nov 9, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48330

What problem does this PR solve?

Issue Number: close #48281

Problem Summary:
Handle lock error getting schema diff key using mvcc interfaces to avoid unexpected schema cache invalidation.

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Running concurrent DDL with stale read requests with injected slow internal transaction commit, there's no mvcc get errors reported, the test result is in the description of this PR

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix unhandled lock error reading schema diff key using mvcc interface.

@cfzjywxk @ti-chi-bot
This is an automated cherry-pick of pingcap#48330
5633957 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 8, 2023
Merged
1 task
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 8, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 8, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 8, 2023
@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 9, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-08 11:40:00.313095367 +0000 UTC m=+3644397.900205512: ☑️ agreed by ekexium.
  • 2023-11-09 03:16:31.772770473 +0000 UTC m=+3700589.359880821: ☑️ agreed by zimulala.

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Nov 9, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 9, 2023

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium, MyonKeminta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Nov 9, 2023

/retest

1 similar comment
@cfzjywxk
Copy link
Contributor

cfzjywxk commented Nov 9, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6927b21 into pingcap:release-7.5 Nov 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekexium ekexium ekexium approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@zimulala zimulala zimulala approved these changes

@zyguan zyguan Awaiting requested review from zyguan

@you06 you06 Awaiting requested review from you06

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees

@cfzjywxk cfzjywxk

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @cfzjywxk @zimulala @MyonKeminta @ekexium